chore: ⬆️ Update CrispStrobe/CrispASR to f7838a306687f22c281d29c250f879a4ab3df2d7#10177
Merged
Conversation
localai-bot
force-pushed
the
update/CRISPASR_VERSION
branch
2 times, most recently
from
7536945 to
935f577
Compare
localai-bot
changed the title
3831a05a95689648444bc38b8cca3ad192e76cc47f090946e0efa6184203a1d0f35e1051502a08dc
localai-bot
force-pushed
the
update/CRISPASR_VERSION
branch
from
935f577 to
5a73a18
Compare
localai-bot
changed the title
7f090946e0efa6184203a1d0f35e1051502a08dcf0491231f604f0f1ef9bfbf6ffa80d308a4da169
localai-bot
force-pushed
the
update/CRISPASR_VERSION
branch
from
7087ff0 to
d319412
Compare
localai-bot
changed the title
f0491231f604f0f1ef9bfbf6ffa80d308a4da169f7838a306687f22c281d29c250f879a4ab3df2d7
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
localai-bot
force-pushed
the
update/CRISPASR_VERSION
branch
from
4e1c766 to
7421082
Compare
The dependency-bump regeneration of this branch reset CMakeLists.txt to master and dropped the prior link-target fix, reintroducing the `cannot find -lcrispasr` failure. Upstream CrispASR (f7838a3) defines the library as the CMake target `crispasr-lib` (with OUTPUT_NAME crispasr); there is no target named `crispasr`, so target_link_libraries falls back to a bare `-lcrispasr` linker flag that cannot be resolved. Point the link at the real target name. Verified locally: CPU cmake-configure of the bumped source generates a gocrispasr link line referencing sources/CrispASR/src/libcrispasr.a with no dangling -lcrispasr. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: Claude:opus-4.8 [Claude Code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: https://github.com/CrispStrobe/CrispASR/compare/13d54e110e1538e0f0bc3af0680b9ab246cfb48d..f7838a306687f22c281d29c250f879a4ab3df2d7