Skip to content

Consistently name VS types with prefix VS#4173

Merged
jakebailey merged 2 commits into
mainfrom
jabaile/vs-rename
Jun 2, 2026
Merged

Consistently name VS types with prefix VS#4173
jakebailey merged 2 commits into
mainfrom
jabaile/vs-rename

Conversation

@jakebailey
Copy link
Copy Markdown
Member

This was missed in review; prefix these so we know they are for VS, and then use the Go-style VS prefix as we had in previous code.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Mechanical rename to consistently use the Go-style VS prefix (instead of Vs) for all Visual Studio-specific types, functions, fields, and a test name. The change updates the LSP proto generator script and its generated output, plus all consumers in the language service, server, fourslash harness, and tests.

Changes:

  • Rename generator entries (and regenerate lsp_generated.go) so VS-specific structures, params/responses, and the VSReferenceKind enum use the VS prefix; ClassifiedTextRun/ClassifiedTextElement become VSClassifiedTextRun/VSClassifiedTextElement.
  • Update all Go call sites (internal/ls/*, internal/lsp/server.go, internal/fourslash/*) to the new identifiers, including ProvideVSReferences, combineVSReferences, handleVSOnAutoInsert, and VerifyBaselineVSFindAllReferences.
  • Update one test function/comment (TestRaceHasChangesVSUpdateWatchState) for naming consistency.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/lsp/lsproto/_generate/generate.mts Rename VS structures/enums in the generator source
internal/lsp/lsproto/lsp_generated.go Regenerated output reflecting renamed types/methods/enum values
internal/lsp/server.go Update handler registrations and capability struct usage to new names
internal/ls/findallreferences.go Rename ProvideVsReferences/symbolAndEntriesToVsReferences and switch to VSClassifiedText* types
internal/ls/crossproject.go Rename combineVsReferences and field accesses on the renamed response type
internal/ls/autoinsert.go Use renamed VSOnAutoInsert* params/response types
internal/ls/signaturehelp.go Use VSClassifiedTextElement/VSClassifiedTextRun
internal/ls/displaypartswriter.go Update runs field and GetRuns signature to VSClassifiedTextRun
internal/fourslash/fourslash.go Rename VerifyBaselineVsFindAllReferences and update VS field/type accesses
internal/fourslash/tests/constructorFindAllReferences1VS_test.go Call renamed verifier
internal/fourslash/tests/findAllRefsForDefaultExportVS_test.go Call renamed verifier
internal/fourslash/tests/findAllRefsInheritedProperties1VS_test.go Call renamed verifier
internal/fourslash/tests/findReferencesAcrossMultipleProjectsVS_test.go Call renamed verifier
internal/fourslash/tests/tsxFindAllReferences1VS_test.go Call renamed verifier
internal/vfs/vfswatch/vfswatch_race_test.go Rename test function and its doc comment to VS casing

@jakebailey jakebailey added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit 9a48038 Jun 2, 2026
22 checks passed
@jakebailey jakebailey deleted the jabaile/vs-rename branch June 2, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants