[Medium] Patch packer for CVE-2026-45570 and CVE-2026-45571#17609
[Medium] Patch packer for CVE-2026-45570 and CVE-2026-45571#17609v-aaditya wants to merge 5 commits into
packer for CVE-2026-45570 and CVE-2026-45571#17609Conversation
|
Buddy Build has been triggered and it has passed. |
mfrw
left a comment
There was a problem hiding this comment.
LGTM ✅ — clean vendor bump to go-git/v5 v5.19.1 + go-billy/v5 v5.9.0.
- Spec hygiene clean:
Release: 15→16,Patch34ordered correctly,%changelogentry matches,BuildRequires: golang >= 1.21 → 1.22aligned with thego.mod/vendor/modules.txtbump togo 1.22. - Vendor delta matches upstream
v5.13.0..v5.19.1(go-git) andv5.6.0..v5.9.0(go-billy) — spot-checked thepathutil.ValidTreePathgate inworktree.doAddFileToIndex, the newworktreeFilesystemwrapper, and the SSH shell-quote fix. - Buddy build green on both arches: buildId=1131745.
- PR checklist ticked, no failing PR checks.
CVE → upstream fix mapping (both land in v5.19.1):
| CVE | GHSA | Severity | Upstream PR |
|---|---|---|---|
| CVE-2026-45571 | GHSA-crhj-59gh-8x96 | Medium | #2100 (worktreeFilesystem) + submodule hardening #2070 #2074 #2078 #2082 |
| CVE-2026-45570 | GHSA-m7cr-m3pv-hgrp | Low | #2068 (transport/ssh shell-quote) |
Nit (non-blocking): patch file is named CVE-2026-45571.patch but it also carries the CVE-2026-45570 fix — might be worth a rename or a comment header in the patch noting both CVE IDs. Same for the PR title. Up to you, not blocking.
Signed-Off By: @mfrw
Updated Patch header and name to add info for |
packer for CVE-2026-45571packer for CVE-2026-45570 and CVE-2026-45571
Updated release number and fixed patch references for CVE-2026-45570 and CVE-2026-45571.
|
Re-triggered Buddy Build and it has passed. |
kgodara912
left a comment
There was a problem hiding this comment.
PR is too big to carry. Instead of doing package upgrade this way, ideally, we should upgrade vendor tarball itself. But before that, we should search for a patch availability, we need to search for the CVEs and see if any patch could address the core issue of vulnerability.
| Patch32: CVE-2026-46598.patch | ||
| Patch33: CVE-2026-33814.patch | ||
| Patch34: CVE-2026-39833.patch | ||
| Patch35: CVE-2026-45570-and-CVE-2026-45571.patch |
There was a problem hiding this comment.
The other files should go as no patch, so your CVE files should go as CVE-2026-45570.patch and CVE-2026-45571.nopatch, you need not to include nopatch file in spec itself.
There was a problem hiding this comment.
Updated patch file name and added .nopatch file for CVE-2026-45570.
I am checking on this ! |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Patch
packerforCVE-2026-45571github.com/go-git/go-git/v5vendor package has been upgraded fromv5.13.0 => v5.19.1.github.com/go-git/go-billy/v5vendor package has been upgraded fromv5.6.0 => v5.9.0, which was needed for compilation of upgradedgithub.com/go-git/go-git/v5.go.modandvendor/module.txtfiles have modified to change the version ofgomodule to1.22, which was required for compilation of upgradedgithub.com/go-git/go-git/v5.BuildRequires: golang >= 1.21has been updated to1.22.This patch also fixes
CVE-2026-45570Change Log
Does this affect the toolchain?
NO
Links to CVEs
Test Methodology