feat: cbz spread page#202
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89a4c1677d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| </head> | ||
| <body> | ||
| <div> | ||
| <img id="spread-image" src="${escapedSrc}" alt="" /> |
There was a problem hiding this comment.
When the reader is used without a same-origin baseUrl/service-worker URL, attachFrameSrc fetches this XHTML and loads it into the iframe via URL.createObjectURL; in that blob document the relative ../../... URL no longer points back to the streamer/archive resource, so every wrapped CBZ image (including spreads) renders as a broken image. Before this change direct CBZ images were converted to an object URL by createHtmlPageFromResource, so the image bytes displayed correctly in the same direct-streamer/custom-fetchResource setup; the wrapper needs an absolute/fetchable source or equivalent embedding for those paths.
Useful? React with 👍 / 👎.
mbret
force-pushed
the
feat/cbz-spread-page
branch
from
f419dbf to
dcbbd90
Compare
1 participant
No description provided.