feat: add Ciphers option to SSL Option

[saiqulhaq]

Faraday 2.11.0 has new SSL option: ciphers

[saiqulhaq]

[saiqulhaq]

This PR is to fix one of these tasks

[olleolleolle]

A detail with this is: the gem will no longer after this change support Faraday 1.

Perhaps we can make it support both versions? A conditional checking for the Faraday version before trying to set the ciphers setting? Something, so that we don't have to maintain a branch with a Faraday 1.x version.

[saiqulhaq]

OK let me try to make it work with Faraday v1 and v2

[saiqulhaq]

RSpec with Ruby v3.3

RSpec with Ruby v2.6, Faraday 2.8

RSpec with Ruby v2.6, Faraday 1.10

  spec.add_dependency 'faraday', '~> 1.10.3'

root@41de205654e6:/app# bundle show faraday
/bundle/gems/faraday-1.10.3

there is an issue with Faraday v1
I had to add gem 'multipart-parser', '~> 0.1.1' to Gemfile manually

I want to add Appraisal, but it's hard since too many combinations of the Ruby and Faraday versions need to be supported.
Even the Rubocop spec is failing in the CI.

FYI, I created a new gem to switch between Ruby versions easily without bloating up our machine -> https://github.com/saiqulhaq/gemdock
https://saiqulhaq.id/very-fast-ruby-gem-development-testing

[olleolleolle]

Ha, I failed to fix the Gemfile right, I _removed_a newline, which is now a lint failure. Sorry!

Gemfile:16:37: C: [Correctable] Layout/TrailingEmptyLines: Final newline missing. (https://rubystyle.guide#newline-eof)
gem 'rubocop-performance', '~> 1.20'

[saiqulhaq]

All checks have passed now @olleolleolle

[olleolleolle]

@saiqulhaq Can you make a rebase on top of latest changes, and force-push this branch? "This branch cannot be rebased due to conflicts" it says in the GitHub web interface, now.

[olleolleolle]

Awesome, are there any tests that cover this new option, either in this repo or in the shared tests?

Thanks for sticking with it!

[saiqulhaq]

I have updated the README file and added RSpec tests to cover the new ciphers option.