Skip to content

RSPEED-3297: remove dead rlsapi_v1 error redactor#1990

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
major:cleanup-dead-redactor
Jun 25, 2026
Merged

RSPEED-3297: remove dead rlsapi_v1 error redactor#1990
tisnik merged 1 commit into
lightspeed-core:mainfrom
major:cleanup-dead-redactor

Conversation

@major

@major major commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

RSPEED-3297: Remove the unused rlsapi_v1 sensitive error redactor and its dedicated tests. The helper no longer has callers, so this keeps the endpoint smaller without changing runtime behavior.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: pi, CodeRabbit
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #RSPEED-3297
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • uv run pytest tests/unit/app/endpoints/test_rlsapi_v1.py
  • uv run make format
  • uv run make verify (fails on existing missing type annotations in tests/integration/container_lifecycle/test_container_lifecycle.py, unrelated to this PR)
  • ~/bin/coderabbit review --agent --base origin/main -c .coderabbit.yaml (0 findings)

Summary by CodeRabbit

  • Chores
    • Simplified backend error handling by removing a previously applied layer of error text masking.
    • Updated automated tests to match the revised error-handling behavior.

Signed-off-by: Major Hayden <major@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 94fda617-1c3b-4328-a253-bf6626dba79d

📥 Commits

Reviewing files that changed from the base of the PR and between 486153a and 9f39ad6.

📒 Files selected for processing (2)
  • src/app/endpoints/rlsapi_v1.py
  • tests/unit/app/endpoints/test_rlsapi_v1.py
💤 Files with no reviewable changes (2)
  • src/app/endpoints/rlsapi_v1.py
  • tests/unit/app/endpoints/test_rlsapi_v1.py
📜 Recent review details
⏰ Context from checks skipped due to timeout. (15)
  • GitHub Check: mypy
  • GitHub Check: integration_tests (3.12)
  • GitHub Check: E2E: server mode / ci / group 2
  • GitHub Check: integration_tests (3.13)
  • GitHub Check: E2E: server mode / ci / group 1
  • GitHub Check: E2E: server mode / ci / group 3
  • GitHub Check: E2E: library mode / ci / group 3
  • GitHub Check: E2E: library mode / ci / group 1
  • GitHub Check: Pylinter
  • GitHub Check: E2E: library mode / ci / group 2
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: E2E Tests for Lightspeed Evaluation job
  • GitHub Check: spectral
  • GitHub Check: build-pr
  • GitHub Check: unit_tests (3.13)

Walkthrough

The PR removes the sensitive-error redaction implementation from src/app/endpoints/rlsapi_v1.py: the re import, compiled regex patterns _PRIVATE_ERROR_BLOCK_PATTERN and _SECRET_KEY_PATTERN, and the _redact_sensitive_error_text function are all deleted. The corresponding test import and parameterized unit tests are removed from the test file.

Changes

Sensitive Error Redaction Removal

Layer / File(s) Summary
Remove redaction function and tests
src/app/endpoints/rlsapi_v1.py, tests/unit/app/endpoints/test_rlsapi_v1.py
Deletes _redact_sensitive_error_text along with its regex patterns from the implementation, and removes the corresponding import and all parameterized test cases from the test module.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the unused rlsapi_v1 error redactor.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik

tisnik commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit 890a6f7 into lightspeed-core:main Jun 25, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants