RSPEED-3297: remove dead rlsapi_v1 error redactor#1990
Conversation
Signed-off-by: Major Hayden <major@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (15)
WalkthroughThe PR removes the sensitive-error redaction implementation from ChangesSensitive Error Redaction Removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok-to-test |
Description
RSPEED-3297: Remove the unused
rlsapi_v1sensitive error redactor and its dedicated tests. The helper no longer has callers, so this keeps the endpoint smaller without changing runtime behavior.Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
uv run pytest tests/unit/app/endpoints/test_rlsapi_v1.pyuv run make formatuv run make verify(fails on existing missing type annotations intests/integration/container_lifecycle/test_container_lifecycle.py, unrelated to this PR)~/bin/coderabbit review --agent --base origin/main -c .coderabbit.yaml(0 findings)Summary by CodeRabbit