Add informational HTTP::XSHeaders compatibility CI job#223
Open
oalders wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 10 10
Lines 1254 1254
Branches 350 350
=======================================
Hits 1186 1186
Misses 14 14
Partials 54 54 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds a test_xsheaders CI job (Perl 5.42) that installs HTTP::XSHeaders and runs the full test suite with PERL5OPT=-MHTTP::XSHeaders, so the suite exercises the XS implementation of HTTP::Headers. Marked continue-on-error so incompatibilities surface without blocking the build. See p5pclub/http-xsheaders#13. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
oalders
force-pushed
the
http-message-xsheaders
branch
2 times, most recently
from
5313c6a to
25aeb02
Compare
…iffs The multi-line as_string() comparisons previously used is(), which on failure dumps both full blobs and leaves whitespace differences (tabs vs folded spaces, header-name casing) nearly invisible. eq_or_diff() renders a line-by-line diff that isolates the differing lines, which is especially useful for triaging the informational HTTP::XSHeaders compat job. Test::Differences is added as a test prerequisite. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
oalders
force-pushed
the
http-message-xsheaders
branch
from
25aeb02 to
845dc4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
test_xsheadersCI job that runs the existingHTTP::Messagetest suite againstHTTP::XSHeadersto verify API compatibility, as requested in p5pclub/http-xsheaders#13.HTTP::XSHeaders, then runsprove -lr twithPERL5OPT=-MHTTP::XSHeaders. Loading the module transparently swaps in its C implementation ofHTTP::Headers, so the suite exercises the XS code path.continue-on-error: true— informational only, so any incompatibilities surface in the logs without blocking the build.Notes
headers-util.t, butHTTP::XSHeadersonly overridesHTTP::Headers/HTTP::Headers::Fast(notHTTP::Headers::Util), so those tests run against the pure-Perl util module as before.🤖 Generated with Claude Code