-
Notifications
You must be signed in to change notification settings - Fork 9
docs: enable dark mode behind theme toggle (default stays light) #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jarugupj
wants to merge
10
commits into
main
Choose a base branch
from
phani/dark-mode-enable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−3
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1518d58
feat(docs): enable dark mode (toggle on, default stays light)
jarugupj 0ad3188
polish(docs): dark-mode card + hero illustrations
jarugupj 0ef618e
revert(docs): keep homepage card illustrations light on dark page
jarugupj 1a16d5b
fix(docs): match tinker-bot src as substring to handle mintlify cdn r…
jarugupj 38417fa
align(docs): swap dark-mode values to kernel brand tokens
jarugupj d71ce01
docs(style): update stale comment to reflect new charcoal bg
jarugupj 11650c6
deslop: shrink dark-mode comments to match existing file style
jarugupj 0ac9d4b
feat(docs): brand-align warning callout in dark mode
jarugupj 470caf9
deslop: shrink warning callout comment to single-line WHAT
jarugupj 51766d4
docs(brand): rename logo/light.svg to logo/white.svg
jarugupj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning callout selector misses amber
Medium Severity
Dark-mode Warning callout overrides use a selector that matches class names containing
yellow, but Mintlify’s Warning callout is styled with Tailwindamberutility classes. Those rules never apply, so Warning panels and icons keep Mintlify’s default harsh amber styling in dark mode instead of the intended brand tints and gold icon.Reviewed by Cursor Bugbot for commit 51766d4. Configure here.