Fix retryablehttp logging adapter for docker/quay clients#440
Merged
Conversation
Fix the adapter that hooks retryablehttp into the logger version-checker uses by passing a pointer to a leveledlogger, so that configured log levels are honoured. The adapter was added in b6ae308 (Track Kubernetes Channels for latest versions) and used correctly there, but the docker and quay clients pass a non-pointer leveledlogger to retryablehttp. Its methods have pointer receivers, so they are not in the value's method set and it does not satisfy retryablehttp's LeveledLogger interface. retryablehttp then falls back to the Printf-based Logger, which logs at info level regardless of the configured level.
davidcollom
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the adapter that hooks retryablehttp into the logger version-checker
uses by passing a pointer to a leveledlogger, so that configured log
levels are honoured.
The adapter was added in b6ae308 (Track Kubernetes Channels for
latest versions) and used correctly there, but the docker and quay
clients pass a non-pointer leveledlogger to retryablehttp. Its methods
have pointer receivers, so they are not in the value's method set and it
does not satisfy retryablehttp's LeveledLogger interface. retryablehttp
then falls back to the Printf-based Logger, which logs at info level
regardless of the configured level.