feat(gallery): support CSS variables being passed to gap#31186
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
approved these changes
Jun 3, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks good to me, awesome work 🚀
thetaPC
approved these changes
Jun 4, 2026
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
LGTM, with a minor suggestion
Contributor
There was a problem hiding this comment.
A test to verify that the fallback is used when the CSS variable is empty would be beneficial. Not sure if we need to add it to layout/gallery.e2e.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The Gallery component currently only supports CSS length strings and numbers being passed to
gap.What is the new behavior?
gapas a string.Does this introduce a breaking change?