[pull] main from danny-avila:main#119
Merged
Merged
Conversation
…essage (#258) * fix(reducer): skip null/undefined entries before coerceMessageLikeToMessage messagesStateReducer maps both input arrays through coerceMessageLikeToMessage without first checking for null/undefined entries. When a provider emits an empty or partial stream chunk, that entry arrives as undefined, and coerceMessageLikeToMessage throws "Cannot read properties of undefined (reading 'role')", which crashes the LangGraph run. Filtering out null/undefined before coercion is a minimal, defensive fix that preserves message order and leaves all existing behavior (id assignment, REMOVE_ALL handling, merge/dedupe) untouched. Refs LibreChat Discussion #12284. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(reducer): coerce and skip null/undefined in a single pass Replace the filter().map() two-pass with a coerceMessages() helper that skips null/undefined while coercing in one loop. Message arrays are iterated frequently, and AGENTS.md calls out minimizing extra passes over them; this also de-duplicates the left/right coercion logic. Behavior is unchanged and reducer.spec.ts still passes. --------- Co-authored-by: Rommy <255708385+cosmic-fire-eng@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Danny Avila <danny@librechat.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )