testing: adding catalog api and large table fetch benchmark testcase#1561
Draft
Anshu6250 wants to merge 4 commits into
Draft
testing: adding catalog api and large table fetch benchmark testcase#1561Anshu6250 wants to merge 4 commits into
Anshu6250 wants to merge 4 commits into
Conversation
Anshu6250
changed the title
| ASSERT_EQ(Connect(connection_string, conn), SQL_SUCCESS) << "Failed to connect to the database."; | ||
|
|
||
| // Generate 90 Lakh (9,000,000) rows by cross-joining two arrays of 3,000 | ||
| std::string query = R"( |
Collaborator
There was a problem hiding this comment.
don't do this, utilise the existing tables like kirltest tables for huge data and all_data_types I think exists for all data types
Anshu6250
force-pushed
the
catalog-api-benchmarks
branch
3 times, most recently
from
9417f45 to
15288a7
Compare
Anshu6250
force-pushed
the
catalog-api-benchmarks
branch
from
15288a7 to
f36e919
Compare
Anshu6250
changed the title
| case SQL_FLOAT: | ||
| case SQL_DOUBLE: col_ptr->data_type = SQL_C_DOUBLE; break; | ||
| case SQL_BIT: col_ptr->data_type = SQL_C_BIT; break; | ||
| default: col_ptr->data_type = SQL_C_CHAR; break; |
Collaborator
There was a problem hiding this comment.
have cases for other data types as well like date, time, numeric, range
| DescribeCol(conn, col_ptr, i); | ||
|
|
||
| switch (col_ptr->data_type) { | ||
| case SQL_BIGINT: |
Collaborator
There was a problem hiding this comment.
same here have cases for other data types as well like date, time, numeric, range
| TEST(DataFetchPerformance, Benchmark_PowerBI_Mimic_NewTimestampTable) { | ||
| auto conn = std::make_shared<ODBCHandles>(); | ||
|
|
||
| std::string connection_string = kDefaultConnectionString + ";AllowHtapiForLargeResults=1;HTAPI_ActivationThreshold=0;"; |
Collaborator
There was a problem hiding this comment.
make all test cases parametrized and run with htapi and without
| DescribeCol(conn, col_ptr, i); | ||
|
|
||
| switch (col_ptr->data_type) { | ||
| case SQL_BIGINT: |
Collaborator
There was a problem hiding this comment.
instead of doing this , use SqlToCdataTypes(col_ptr) instead , as here we are not doing conversion simply returning as string, maybe can have a separate test case to bind with SQL_C_CHAR only
Anshu6250
force-pushed
the
catalog-api-benchmarks
branch
from
c2a572d to
a21251d
Compare
Anshu6250
force-pushed
the
catalog-api-benchmarks
branch
from
a21251d to
c73f564
Compare
Collaborator
|
Collaborator
|
@Anshu6250 In this PR, create the cmake target only. We can make the CI changes in the next one. |
| break; | ||
| case SQL_VARCHAR: | ||
| case SQL_CHAR: | ||
| case SQL_NUMERIC: |
Collaborator
There was a problem hiding this comment.
why are we returning SQL_NUMERIC and SQL_DECIMAL as SQL_C_CHAR ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.