fix(core): buffer chat compression telemetry#28162
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the telemetry handling for chat compression events by moving log emission and metric recording into the telemetry buffer. This change ensures that these operations are managed consistently with other buffered telemetry events, improving reliability and performance. The associated regression test has been updated to confirm that the buffered callback correctly triggers both the log emission and the metrics recording. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/M
|
There was a problem hiding this comment.
Code Review
This pull request wraps the OpenTelemetry logging and metrics recording for chat compression events inside a bufferTelemetryEvent callback within logChatCompression. It also updates the corresponding unit tests in loggers.test.ts to mock and verify this buffering behavior. I have no feedback to provide as there are no review comments and the changes are correct.
Summary
Fixes #23445
Validation