feat: tag runners with github labels#5185
Open
edersonbrilhante wants to merge 1 commit into
Open
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
edersonbrilhante
force-pushed
the
add-github-labels-to-ec2-tags
branch
2 times, most recently
from
86788b2 to
5801494
Compare
edersonbrilhante
force-pushed
the
add-github-labels-to-ec2-tags
branch
from
5801494 to
fe7d7d5
Compare
edersonbrilhante
requested review from
Brend-Smits,
guicaulada,
npalm and
stuartp44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds EC2 tags for the GitHub runner labels registered through the JIT runner flow.
Now that dynamic labels are supported, runners created from the same multi-runner entry can register with different label sets. Before this change, AWS-side inspection only had the instance/runner identity, so checking the exact labels required going to GitHub.
The labels are taken from
runnerConfig.data.runner.labels, so the EC2 tags reflect the labels GitHub registered for that runner. The instance create-tags policy was also updated to allow the new label tag keys.Test Plan
Deploy the lambda, run workflow and check the new labels
Related Issues
None