vulkan: disable MMVQ on AMD UMA devices#24966
Open
winstonma wants to merge 1 commit into
Open
Conversation
MMVQ's quantization overhead outweighs bandwidth savings on UMA where CPU and GPU share the same memory pool.
Contributor
|
Your benchmark is invalid, you don't even show the baseline. FORCE_MMVQ enables it anywhere, which is not default behaviour. Also, here's a counter example on AMD Strix Halo: before is just base master, after is with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MMVQ's quantization overhead outweighs bandwidth savings on UMA where CPU and GPU share the same memory pool.
Overview
This is the testing result before the patch is written (tested on AMD UMA only):
tg value jump from 28.78 to 30.79 on my device.
The patch is applied to AMD path because this is the device that I could test.
Additional information
The following explanation is written by Claude:
The MMVQ path quantizes the input vector to Q8_1 before dispatching, which adds CPU-side work and an extra quantization kernel on the GPU. On a discrete GPU with fast VRAM, that overhead is worth it because it reduces the weight-loading bandwidth. On my AMD UMA device, the CPU and GPU share the same LPDDR5X pool — the quantization step costs real time and the bandwidth savings are smaller because my device is already memory-bandwidth-limited from both sides simultaneously.
The effectiveness of the patch depends on how much time each model actually spends in these kernels relative to everything else:
Based on the test I see that this patch would
Requirements