docs(architecture): ADR for plugins and extensions taxonomy#589
Open
seanspeaks wants to merge 1 commit into
Open
docs(architecture): ADR for plugins and extensions taxonomy#589seanspeaks wants to merge 1 commit into
seanspeaks wants to merge 1 commit into
Conversation
Defines a three-tier model for what's pluggable in Frigg, distinguishing Core Plugins (required infrastructure with defaults — provider, queue, encryption), Application Extensions (optional cross-cutting features on appDefinition.extensions), and Integration Extensions (off-the-shelf handler bundles on IntegrationBase.Definition.extensions). Grounds the model in existing prototypes: the packages/core/extensions system on claude/frigg-netlify-exploration-aY2Bh for Tier 2, and the this.extensions pattern in the frigg-2.0 downstream repos for Tier 3. Calls out current shape mismatches (array vs object, constructor vs static Definition, vocabulary collision) and proposes resolutions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
|
3 tasks
3 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Adds
docs/architecture/ADR-EXTENSIONS.md— a proposed three-tier taxonomy for what's pluggable in Frigg:appDefinition.extensions. Grounded in thepackages/core/extensions/prototype onclaude/frigg-netlify-exploration-aY2Bhand the reference@friggframework/extension-db-credentialspackage.Definition.extensions. Grounded in thethis.extensionsprototypes inlefthookhq/frigg-2.0-prototyping,stack-global--frigg-2.0, andvartopia--frigg-2.0.What the ADR resolves
extensions: [...](array); the Tier 3 prototypes useextensions: { name: {...} }(object). The ADR keeps both — they model different problems — and explains why.this.extensionsvsstatic Definition.extensions. Recommends moving Tier 3 wiring out of the constructor and onto the static Definition, with string-name handler binding done by the framework at instantiation.Status
Open questions in the ADR
Test plan
🤖 Generated with Claude Code