Fix CPE generation for Citrix Workspace without YYMM suffix (#46811)#47545
Fix CPE generation for Citrix Workspace without YYMM suffix (#46811)#47545mostlikelee wants to merge 1 commit into
Conversation
A single Citrix Workspace install produces several 'programs' rows (e.g. 'Citrix Workspace', 'Citrix Workspace(DV)', 'Citrix Workspace Inside') whose names lack the YYMM release suffix. The existing version normalizer only matched names like 'Citrix Workspace 2603', so these rows kept their raw file version (e.g. 25.7.1.6) in the generated CPE and failed to match NVD. Broaden the matcher to also normalize any 'Citrix Workspace*' program published by 'Citrix Systems, Inc.' on Windows.
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR fixes CPE generation for Citrix Workspace installations on Windows. The changes expand the CPE software transformer to detect Citrix Workspace entries that originate from the Windows programs source without YYMM-style release naming, then normalize their version strings to match NVD format (e.g., 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47545 +/- ##
==========================================
- Coverage 67.18% 67.18% -0.01%
==========================================
Files 3548 3548
Lines 228890 228892 +2
Branches 11909 11909
==========================================
- Hits 153782 153777 -5
- Misses 61263 61268 +5
- Partials 13845 13847 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Related issue: Resolves #46811
A single Citrix Workspace install produces several
programsrows (e.g.Citrix Workspace,Citrix Workspace(DV),Citrix Workspace Inside) whose names lack theYYMMrelease suffix. The version normalizer only matched names likeCitrix Workspace 2603, so these rows kept their raw file version (e.g.25.7.1.6) in the generated CPE and failed to match NVD. Broadened the matcher to normalize anyCitrix Workspace*program published byCitrix Systems, Inc.on Windows.Checklist for submitter
changes/.SELECT *is avoided, SQL injection is prevented (no SQL changes; version normalization only).Testing
TestMutateSoftwareregression cases for Incorrect CPE generated for Cisco Workspace (Windows) #46811).programsrows on a Windows host).Summary by CodeRabbit