Skip to content

[Celestica] Ladakh800bcls: Agent Test: Fix AgentQueuePerHostL2Tests* AgentQueuePerHostRouteTests* init conf…#1301

Closed
cel-gl wants to merge 1 commit into
facebook:mainfrom
cel-gl:multi_agent_cases_fix
Closed

[Celestica] Ladakh800bcls: Agent Test: Fix AgentQueuePerHostL2Tests* AgentQueuePerHostRouteTests* init conf…#1301
cel-gl wants to merge 1 commit into
facebook:mainfrom
cel-gl:multi_agent_cases_fix

Conversation

@cel-gl

@cel-gl cel-gl commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
    clang-format.............................................................Passed
    shellcheck...........................................(no files to check)Skipped
    shfmt................................................(no files to check)Skipped
    trim trailing whitespace.................................................Passed
    fix end of files.........................................................Passed
    check yaml...........................................(no files to check)Skipped
    check json...........................................(no files to check)Skipped
    check for merge conflicts................................................Passed
    ruff check...........................................(no files to check)Skipped
    ruff format..........................................(no files to check)Skipped
    Prevent sai_impl in fboss manifest.......................................Passed

Summary

when run AgentQueuePerHostL2Tests* AgentQueuePerHostRouteTests* test cases, error info , agent can't create unit 1, because error config generated, need change initconfig

Replaced the legacy, multi-NPU-unaware configuration helper calls in AgentNeighborTest::initialConfig() with the multi-NPU-aware overloads:

Updated oneL3IntfTwoPortConfig branches to take explicit hardware arguments:
ensemble.getPlatformMapping()
asic
ensemble.supportsAddRemovePort()
asic->desiredLoopbackModes()
ensemble.getSw()->getPlatformType() (Crucially provides the specific platform type)
By explicitly passing PlatformType::PLATFORM_LEH800BCLS, the configuration generator (genPortVlanCfg()) detects the dual-NPU hardware layout and generates a complete, valid switch configuration covering both SwitchID(0) and SwitchID(1).
This ensures all SDK resources and units are correctly mapped and initialized

Test Plan

run test cases AgentQueuePerHostL2Tests* AgentQueuePerHostRouteTests* on unit 0 and 1 all passed

=== Cold boot: AgentQueuePerHostL2Test.VerifyHostToQueueMappingClassID (switch_id=1) ===
Waiting for config files...
Config files ready after 1s
Starting hw_agent processes...
=== Warm boot: AgentQueuePerHostL2Test.VerifyHostToQueueMappingClassID (switch_id=1) ===

=== Test Results ===
Cold boot: PASSED (exit code 0)
Warm boot: PASSED (exit code 0)

=== Cold boot: AgentQueuePerHostL2Test.VerifyHostToQueueMappingClassID (switch_id=1) ===
Waiting for config files...
Config files ready after 1s
Starting hw_agent processes...
=== Warm boot: AgentQueuePerHostL2Test.VerifyHostToQueueMappingClassID (switch_id=1) ===

=== Test Results ===
Cold boot: PASSED (exit code 0)
Warm boot: PASSED (exit code 0)

passed === Cold boot: AgentQueuePerHostRouteTest/0.VerifyHostToQueueMappingClassID (switch_id=0) ===
Waiting for config files...
Config files ready after 1s
Starting hw_agent processes...
=== Warm boot: AgentQueuePerHostRouteTest/0.VerifyHostToQueueMappingClassID (switch_id=0) ===

=== Test Results ===
Cold boot: PASSED (exit code 0)
Warm boot: PASSED (exit code 0)

=== Cold boot: AgentQueuePerHostRouteTest/1.VerifyHostToQueueMappingClassIDBlock (switch_id=1) ===
Waiting for config files...
Config files ready after 1s
Starting hw_agent processes...
=== Warm boot: AgentQueuePerHostRouteTest/1.VerifyHostToQueueMappingClassIDBlock (switch_id=1) ===

=== Test Results ===
Cold boot: PASSED (exit code 0)
Warm boot: PASSED (exit code 0)

@cel-gl cel-gl requested a review from a team as a code owner June 16, 2026 02:20
@meta-cla meta-cla Bot added the CLA Signed label Jun 16, 2026
@cel-gl cel-gl changed the title Fix AgentQueuePerHostL2Tests* AgentQueuePerHostRouteTests* init conf… [Celestica] Ladakh800bcls: Agent Test: Fix AgentQueuePerHostL2Tests* AgentQueuePerHostRouteTests* init conf… Jun 16, 2026
@cel-gl

cel-gl commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

@jagpalgill

@meta-codesync

meta-codesync Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D109721421.

@meta-codesync meta-codesync Bot closed this in ec14e17 Jun 25, 2026
@meta-codesync meta-codesync Bot added the Merged label Jun 25, 2026
@meta-codesync

meta-codesync Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@jrallapalli merged this pull request in ec14e17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant