[eas-cli] Simplify 2FA now that SMS is no longer supported#3859
Open
wschurman wants to merge 1 commit into
Open
[eas-cli] Simplify 2FA now that SMS is no longer supported#3859wschurman wants to merge 1 commit into
wschurman wants to merge 1 commit into
Conversation
wschurman
force-pushed
the
06-12-_eas-cli_simplify_2fa_now_that_sms_is_no_longer_supported
branch
2 times, most recently
from
0c71944 to
9c874d3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3859 +/- ##
==========================================
- Coverage 58.42% 58.38% -0.04%
==========================================
Files 917 917
Lines 39994 39953 -41
Branches 8418 8407 -11
==========================================
- Hits 23363 23322 -41
Misses 16536 16536
Partials 95 95 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wschurman
force-pushed
the
06-12-_eas-cli_simplify_2fa_now_that_sms_is_no_longer_supported
branch
from
9c874d3 to
f427875
Compare
|
Subscribed to pull request
Generated by CodeMention |
wschurman
force-pushed
the
06-12-_eas-cli_simplify_2fa_now_that_sms_is_no_longer_supported
branch
from
f427875 to
f56c6ed
Compare
|
✅ Thank you for adding the changelog entry! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SMS 2FA is no longer supported, only authenticator (TOTP). Therefore, we can remove parts of the no-browser login flow that supported SMS 2FA.
Equivalent of expo/expo#46879.
How
Remove the fallback device picker and SMS logic. The flow is now:
ONE_TIME_PASSWORD_REQUIREDerror, ask for OTP/backup code.Test Plan
neas login --no-browserto an account that has 2fa set up.