Refactor/remove prysk#87
Conversation
.github/workflows/matrix-all.yml .github/workflows/matrix-exasol.yml
|
| def test_parse_subcommand(command: list[str], sample_module: Path): | ||
| result = _run(command, "parse", sample_module.name, cwd=sample_module.parent) | ||
|
|
||
| assert result.stderr == "" |
There was a problem hiding this comment.
Can --debug cause any stderr output?
There was a problem hiding this comment.
I did not find any reference to CLI option --debug except in _cli.py.
Hence, I don't assume CLI option --debug to cause any specific output.
However, with or without CLI option --debug I think, output to stderr is possible.
There was a problem hiding this comment.
I meant the --debug in _run(...). But maybe I am lacking the context, so feel free to ignore it.
There was a problem hiding this comment.
My current guess is, that the CLI option --debug is used to prevent subprocess.run() to raise errors during integration tests.
Actually I think this is not optimal and could be avoided by using click.CliRunner().
I also see some more questionable things, e.g. ec_path = shutil.which("ec").
There was a problem hiding this comment.
The tests are not perfect, but better then prysk. For that reason, I suggest we merge them for the moment and we create a ticket to refactor the cli and make it easier testable.
There was a problem hiding this comment.
3 participants
No description provided.