Skip to content

Avoid dynamic looking in createExportWrapper. NFC#27180

Merged
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:remove_redundant_assert
Jun 27, 2026
Merged

Avoid dynamic looking in createExportWrapper. NFC#27180
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:remove_redundant_assert

Conversation

@sbc100

@sbc100 sbc100 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@sbc100 sbc100 requested a review from kripken June 24, 2026 23:54
@sbc100 sbc100 changed the title Remove redundant assert from createExportWrapper Remove redundant assert from createExportWrapper. NFC Jun 25, 2026
@sbc100 sbc100 enabled auto-merge (squash) June 25, 2026 06:48
Comment thread src/preamble.js
@sbc100 sbc100 force-pushed the remove_redundant_assert branch from 1240a21 to 171faea Compare June 25, 2026 23:39
@sbc100 sbc100 changed the title Remove redundant assert from createExportWrapper. NFC Avoid dynamic looking in createExportWrapper. NFC Jun 25, 2026
@sbc100 sbc100 requested a review from kripken June 25, 2026 23:40
@sbc100

sbc100 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

Re-titled to express what this change is really about.

@sbc100 sbc100 force-pushed the remove_redundant_assert branch 2 times, most recently from d86b28a to de75152 Compare June 26, 2026 00:46
@sbc100 sbc100 disabled auto-merge June 26, 2026 16:23
@sbc100 sbc100 force-pushed the remove_redundant_assert branch 3 times, most recently from 5dcb4ab to 98c23bf Compare June 26, 2026 23:58
`assignWasmExports` is only ever called from `assignWasmExports` which
already contains assertions for each export.
@sbc100 sbc100 force-pushed the remove_redundant_assert branch from 98c23bf to d515c2b Compare June 27, 2026 01:11
@sbc100 sbc100 merged commit b012a86 into emscripten-core:main Jun 27, 2026
23 of 39 checks passed
@sbc100 sbc100 deleted the remove_redundant_assert branch June 27, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants