Fix MODULARIZE=instance ready promise to wait for run dependencies#27040
Closed
sbc100 wants to merge 1 commit into
Closed
Fix MODULARIZE=instance ready promise to wait for run dependencies#27040sbc100 wants to merge 1 commit into
sbc100 wants to merge 1 commit into
Conversation
sbc100
force-pushed
the
modularize-instance-ready
branch
from
2a78b03 to
103060e
Compare
Collaborator
Author
|
I think we can close this in favor of #27059 |
auto-merge was automatically disabled
June 8, 2026 17:38
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change the
init()function can return/resolve before the instance is ready.