Add assertFilesMatch helper. NFC#27032
Merged
Merged
Conversation
dschuff
reviewed
May 29, 2026
| self.fail(fail_message) | ||
|
|
||
| def assertFileContents(self, filename, contents): | ||
| def assertFileContents(self, filename, contents, tofile=None): |
Member
There was a problem hiding this comment.
If we didn't reuse assertFileContents, we could just use the builtin filecmp module. This would be simple and maybe faster than reading both files into memory, perhaps at the cost of not being able to print actual diffs. Would that be desirable?
Collaborator
Author
There was a problem hiding this comment.
I think I prefer to have the existing logic in place for nicely displaying diffs.
I don't think there is any perfermance issues since since we don't have any huge files checked in at all. They all measured in kb.
dschuff
approved these changes
May 29, 2026
This works just like the `assertFileContents` but take two filenames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works just like the
assertFileContentsbut take two filenames. The advantage of this appoach is that the caller does not need to read the file into memory and the filename is not lost (i.e. it can be shown accurately in the diff)