Fix COPY FROM STDIN over pglite-socket#1028
Open
bahoo wants to merge 1 commit into
Open
Conversation
COPY ... FROM STDIN is a stateful sub-protocol: the CopyData ('d') /
CopyDone ('c') / CopyFail ('f') messages that follow the query must reach
PGlite in the same execProtocolRawStream call as the query itself —
PGlite cannot resume a copy started in a previous call. The handler
previously dispatched every wire message as its own call, which
desynchronized the connection mid-COPY and left buffered response bytes
that corrupted the next client's startup handshake.
The handler now detects COPY ... FROM STDIN in simple-protocol queries,
synthesizes the CopyInResponse the client is waiting for, buffers the
copy sub-protocol messages, and submits the whole sequence as one call,
stripping the duplicate CopyInResponse from PGlite's response.
Known limitations, called out in the PR: the COPY payload is buffered in
memory, extended-protocol COPY is not detected, and errors from the COPY
statement itself are reported after the data has been sent.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bahoo
force-pushed
the
fix/socket-copy-from-stdin
branch
from
0eab42c to
814be44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COPY ... FROM STDIN is a stateful sub-protocol: the CopyData ('d') / CopyDone ('c') / CopyFail ('f') messages that follow the query must reach PGlite in the same execProtocolRawStream call as the query itself — PGlite cannot resume a copy started in a previous call. The handler previously dispatched every wire message as its own call, which desynchronized the connection mid-COPY and left buffered response bytes that corrupted the next client's startup handshake.
The handler now detects COPY ... FROM STDIN in simple-protocol queries, synthesizes the CopyInResponse the client is waiting for, buffers the copy sub-protocol messages, and submits the whole sequence as one call, stripping the duplicate CopyInResponse from PGlite's response.
Known limitations, called out in the PR: the COPY payload is buffered in memory, extended-protocol COPY is not detected, and errors from the COPY statement itself are reported after the data has been sent.