Add test cases for PropertyGrid.AddTab#14574
Closed
SimonZhao888 wants to merge 3 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds unit test coverage for PropertyGrid.AddTab, supporting the broader effort to improve PropertyGrid coverage from issue #12055.
Changes:
- Adds tests for adding a new tab type.
- Adds coverage for duplicate tab type insertion behavior.
- Adds coverage for associating one or multiple components with a tab.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LeafShi1
reviewed
May 29, 2026
91 tasks
SimonZhao888
changed the title
SimonZhao888
changed the title
added 2 commits
June 4, 2026 16:53
ricardobossan
approved these changes
Jun 8, 2026
ricardobossan
left a comment
ricardobossan
left a comment
Member
There was a problem hiding this comment.
Other than a small comment, all LGTM!
|
|
||
| // AddTab does not unconditionally append; it picks an insertion index | ||
| // based on tab kind and alphabetical order. Insertion order is verified | ||
| // separately by PropertyGrid_AddTab_OrdersCustomTabsAlphabetically. |
Member
There was a problem hiding this comment.
This 'PropertyGrid_AddTab_OrdersCustomTabsAlphabetically' no longer exists, so it should not be referenced in this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #12055
Proposed changes
Microsoft Reviewers: Open in CodeFlow