Fix PR-review bot false positives (80-char rule, enable/disable)#25237
Merged
Conversation
… enable/disable The PR-review bot's prompt instructed it to flag lines over 80 characters, but no such rule exists in the repo (markdownlint MD013 is disabled and STYLE.md never mentions it). Remove that instruction from pr-review.yml. Also clarify the STYLE.md word list so "turn on/off" applies to UI toggles while "enable/disable" stays acceptable in general prose, matching STYLE.md's own example. This stops the bot from flagging every "enable" as a violation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
reviewed
Jun 2, 2026
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
No issues found. The two changes are well-targeted and accurate:
- Removed fabricated 80-char rule from
.github/workflows/pr-review.yml— correctly eliminates a bot instruction that had no backing rule in STYLE.md or markdownlint config. - Clarified enable/disable vs turn on/turn off in
STYLE.md— the new paragraph correctly scopes "turn on/off" to UI toggles and permits "enable/disable" in general prose, matching the existing ✅ example already in the doc.
akristen
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An audit of docker-agent review comments across recent merged PRs surfaced two
recurring false positives, both traced to their source:
.github/workflows/pr-review.yml) instructed it to flaglines over 80 characters, but no such rule exists — markdownlint MD013 is
disabled and STYLE.md never mentions it. The bot itself conceded this
mid-review on a past PR. Removed the instruction.
flagged every "enable"/"disable" as a violation. Added a note clarifying that
"turn on/off" is for UI toggles while "enable/disable" is fine in general
prose.
Learnings
additional-promptblock in.github/workflows/pr-review.yml(viadocker/cagent-action), plusSTYLE.mdandCOMPONENTS.mdloaded as prompt files. That prompt — not justthe style guides — is the source of truth for what the bot flags, so review
noise can be tuned there directly.
Generated by Claude Code