Skip to content

man: remove tools.go in favor of tools directive#7041

Merged
thaJeztah merged 2 commits into
docker:masterfrom
thaJeztah:no_tools
Jun 10, 2026
Merged

man: remove tools.go in favor of tools directive#7041
thaJeztah merged 2 commits into
docker:masterfrom
thaJeztah:no_tools

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@docker-agent docker-agent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR modernizes the Docker CLI's tool dependency management by replacing the legacy //go:build tools blank-import pattern (man/tools.go) with Go 1.25's native tool directive in vendor.mod.

Changes reviewed:

  • man/tools.go — deleted: the old //go:build tools / blank-import file for go-md2man/v2 is superseded by the tool directive on Go ≥ 1.21 (and fully supported in 1.25).
  • vendor.modgithub.com/cpuguy83/go-md2man/v2 added to a grouped tool (...) block and moved from the direct require section to // indirect (correct: the // indirect annotation for tool-only dependencies is the expected Go modules behaviour when no production code imports the package).

No issues found. The grouped tool (...) syntax is valid in Go 1.25, the // indirect marking is semantically correct for tool-only deps, and go mod vendor will continue to vendor the tool sources via the directive. Removal of the man/tools.go file is safe given the project requires Go 1.25+.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah merged commit b680c49 into docker:master Jun 10, 2026
166 of 169 checks passed
@thaJeztah thaJeztah deleted the no_tools branch June 10, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants