Fix login shell argv[0] parsed as flag in session files#10
Open
noomzopendream wants to merge 1 commit into
Open
Fix login shell argv[0] parsed as flag in session files#10noomzopendream wants to merge 1 commit into
noomzopendream wants to merge 1 commit into
Conversation
Login shells use a '-' prefix in argv[0] (e.g., '-fish' instead of 'fish') as a Unix convention. When this is written literally into a Kitty session file as 'launch -fish', the session parser interprets '-f' as an unknown flag, producing 'Unknown flag: -f. Did you mean: -h?' Strip the leading '-' from the first cmdline element when saving sessions, so login shells are written as 'launch fish' — valid Kitty session syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login shells use a
-prefix in argv[0] (e.g.,-fishinstead offish) as a Unix exec convention. When this is written literally into a Kitty session file as:Kitty's session parser interprets
-fas an unknown flag:Strip the leading
-from the first cmdline element incmdline_to_str()so login shells are emitted aslaunch fish— valid Kitty session syntax.Reproduction
kitty-save-session-all.shsaves a session withlaunch -fishkitty --detach --session=...fails withUnknown flag: -fFix
Check if the first element of the cmdline starts with
-and is longer than 1 character (the login shell indicator), then strip it before writing to the session file.