fix(exim-logs): make set_id optional in failed-auth pattern#1835
Open
dvlinuxx-max wants to merge 1 commit into
Open
fix(exim-logs): make set_id optional in failed-auth pattern#1835dvlinuxx-max wants to merge 1 commit into
dvlinuxx-max wants to merge 1 commit into
Conversation
Exim omits the (set_id=...) field when server_set_id is unset or the auth data cannot be parsed, e.g.: login authenticator failed for (U8kjDR) [IP]: 535 Incorrect authentication data The grok pattern required (set_id=...), so these brute-force failures were never parsed and the source IPs were never banned. This makes the trailing set_id group optional. Existing log lines that include set_id still match and still populate target_user, so current parser tests are unaffected. Closes crowdsecurity#978
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exim omits the (set_id=...) field when server_set_id is unset or the auth data cannot be parsed, e.g.:
login authenticator failed for (U8kjDR) [IP]: 535 Incorrect authentication data
The grok pattern required (set_id=...), so these brute-force failures were never parsed and the source IPs were never banned. This makes the trailing set_id group optional. Existing log lines that include set_id still match and still populate target_user, so current parser tests are unaffected.
Closes #978
Description
Checklist