mantle/kola: remove --allow-rerun-success feature, keep flag as no-op#4559
Open
nikita-dubrovskii wants to merge 1 commit into
Open
mantle/kola: remove --allow-rerun-success feature, keep flag as no-op#4559nikita-dubrovskii wants to merge 1 commit into
nikita-dubrovskii wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the test rerun logic in mantle/kola/harness.go to explicitly handle four scenarios based on rerun results and success tags. The feedback suggests adding a log message for the scenario where a rerun passes but the original failure is preserved due to missing tags, which helps avoid user confusion when seeing a 'PASS' followed by an overall 'FAIL'.
jbtrystram
reviewed
May 20, 2026
nikita-dubrovskii
force-pushed
the
fix_rerun_logic
branch
from
df1d64a to
330f472
Compare
Remove all code implementing the --allow-rerun-success feature while keeping the flag for backward compatibility (it now does nothing). With this change, --rerun now always succeeds if failed tests pass on retry, effectively behaving as the old '--rerun --allow-rerun-success tags=all' combination. Issue: coreos#4546
nikita-dubrovskii
force-pushed
the
fix_rerun_logic
branch
from
330f472 to
c1f2135
Compare
nikita-dubrovskii
changed the title
dustymabe
approved these changes
Jun 15, 2026
Comment on lines
-186
to
-196
| { | ||
| // For this one we see it sometimes when I/O is really slow, which is often | ||
| // more of an indication of a problem with resources in our pipeline rather | ||
| // than a problem with the software we are testing. We'll mark it as warnOnly | ||
| // so it's non-fatal and also allow for a rerun of a test that goes on to | ||
| // fail that had this problem to ultimately result in success. | ||
| desc: "kernel soft lockup", | ||
| match: regexp.MustCompile("watchdog: BUG: soft lockup - CPU"), | ||
| warnOnly: true, | ||
| allowRerunSuccess: true, | ||
| }, |
Member
There was a problem hiding this comment.
is it safe to remove this one entirely?
we probably just want to remove line 195 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all code implementing the
--allow-rerun-successfeature while keeping the flagfor backward compatibility (it now does nothing).
With this change,
--rerunnow always succeeds if failed tests pass on retry, effectivelybehaving as the old
--rerun --allow-rerun-success tags=allcombination.Issue: #4546