feat(graphql): add hasLinkedSentryLogin to Me type#1168
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bdec836 to
38b5d4b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 1325 1325
Lines 50860 50866 +6
Branches 1626 1626
==========================================
+ Hits 46739 46742 +3
- Misses 3815 3818 +3
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
| from graphql import GraphQLResolveInfo | ||
|
|
||
| from codecov_auth.models import Owner, OwnerProfile | ||
| from services.sentry import is_sentry_user |
There was a problem hiding this comment.
nit, don't need to fix in this PR, there is a standard way of ordering imports. This shouldn't be in between codecov_auth. I don't have the PEP on hand, but again, don't have to fix now
| privateAccess: Boolean | ||
| termsAgreement: Boolean | ||
| supportPin: String | ||
| hasLinkedSentryLogin: Boolean! |
There was a problem hiding this comment.
I'm guilty of this too (see support pin), can we alphabetize these? Also nit, doesn't have to be this PR
|
I believe Owner.sentry_user_id is a slightly different concept from Sentry Auth login. I think what we may be looking for is the |
calvin-codecov
left a comment
There was a problem hiding this comment.
I think using owner.user.sentry_user.exists() would be a better indicator
Confirms the SentryUser row actually exists via owner.user.sentry_user.exists() rather than trusting the denormalized sentry_user_id text field on Owner. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
hasLinkedSentryLogin: Boolean!to theMeGraphQL typeowner.user.sentry_user.exists()— confirms theSentryUserrow actually exists rather than trusting the denormalizedsentry_user_idtext field onOwnerFor Calvin
This is the backend half. Gazebo needs to query
me { hasLinkedSentryLogin }and show a deprecation banner when it'strue— pointing users to reconnect via GitHub/GitLab/Bitbucket before July 8.🤖 Generated with Claude Code