perf: Optimize N+1 query in ProcessFlakesTask#1163
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause analysis identified an N+1 query pattern within the
app.tasks.flakes.ProcessFlakesTaskinapps/worker/services/test_analytics/ta_process_flakes.py.Specifically:
process_flakes_for_commitfunction fetched uploads for a commit.process_single_uploadwould callget_testruns(upload), resulting in a separate database query for testruns per upload. This led to N+1 queries (1 for uploads + N for testruns).handle_passwas calling.save()individually for each expiring flake, leading to further N database writes.This PR addresses these N+1 issues by:
get_all_testrunsto fetch all relevant testruns for all uploads in a single batched query, grouping them byupload_id.process_flakes_for_committo use this new batched fetch, passing the pre-fetched testruns toprocess_single_upload.handle_passto append expiring flakes to a list, which are then bulk-updated inprocess_flakes_for_commitafter the loop completes.These changes reduce the number of database queries from an N+1 pattern to a fixed number of queries, significantly improving performance for tasks processing multiple uploads and testruns.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YS4