perf: Fix N+1 query in ProcessFlakesTask#1160
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 1324 1324
Lines 50851 50859 +8
Branches 1626 1626
==========================================
+ Hits 46730 46736 +6
- Misses 3815 3817 +2
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue identified in
app.tasks.flakes.ProcessFlakesTask.Problem:
Previously,
process_flakes_for_commitwould iterate over eachReportSession(upload) and callprocess_single_upload. Insideprocess_single_upload,get_testruns(upload)would execute a separate database query forTestrunobjects for each individual upload. This resulted in an N+1 query pattern, where N is the number of uploads.Additionally,
handle_passwould callflake.save()individually for each flake that reached its expiration threshold, leading to further unnecessary database calls.Solution:
get_testruns_for_uploadsto fetch all relevantTestrunobjects for all uploads in a single database query. These are then grouped byupload_idin memory.process_single_upload: Modifiedprocess_single_uploadto accept the pre-fetched and groupedTestrunobjects, eliminating the need for per-upload database queries.handle_passno longer callsflake.save()individually. Instead, flakes that reach their expiration threshold are moved to a separateexpired_flakeslist. This list, along with thecurr_flakes, is then included in the singleFlake.objects.bulk_createcall at the end ofprocess_flakes_for_commit, ensuring all updates are persisted efficiently.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YS3