Deprecate the legacy connection-named aliases#4033
Merged
Conversation
`cider-current-connection', `cider-connections', `cider-map-connections' and `cider-connection-type-for-buffer' are leftovers from before the connection->REPL terminology change and have no remaining callers in CIDER. Mark them obsolete in favor of the `cider-repl' names so the byte-compiler steers any external code off them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four
cider-*-connection*aliases are leftovers from before the connection -> REPL terminology change and have zero callers anywhere in lisp/, test/, or doc/. Mark them obsolete (pointing at thecider-replnames) so the byte-compiler nudges any external code off them:cider-current-connection->cider-current-replcider-connections->cider-replscider-map-connections->cider-map-replscider-connection-type-for-buffer->cider-repl-type-for-bufferThe aliases still work; this just deprecates them (the graceful removal path) rather than hard-deleting public API. Surfaced by the session/connection deep dive. Clean
--warnings-as-errorscompile.