Deprecate cider-ensure-op-supported#4028
Merged
Merged
Conversation
Op support is now enforced centrally by the nREPL senders (see `cider--ensure-request-op-supported'), so commands no longer call this. Mark it obsolete so the byte-compiler flags any new use - simpler and more idiomatic than a custom lint for the same purpose. The function still works for any external callers. Drop the now-dead test spies/stubs and the per-command "op not supported" specs; that behavior is covered by the central helper's tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the guard-centralization work (#4027). Op support is now enforced centrally by the nREPL senders (
cider--ensure-request-op-supported), so no command callscider-ensure-op-supportedanymore.Rather than add a custom lint asserting it has zero callers, just
make-obsoleteit: the byte-compiler then flags any new use, and the compile job runs--warnings-as-errors, so a new internal call fails CI for free. Simpler and more idiomatic. The function still works for any external callers.Also drops the now-dead test references left over from the sweep: the spies/stubs on it (no-ops, since commands no longer call it) and the per-command "op not supported" specs - that behavior is covered by the central
cider--ensure-request-op-supportedtests.Clean
eldev -dtT compile --warnings-as-errors(no obsolete warnings, since our own code has no callers) and full suite green.