feat(clerk-js,localizations,shared,ui): Render per-seat costs for subscription items#8737
feat(clerk-js,localizations,shared,ui): Render per-seat costs for subscription items#8737dstaley wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| })} | ||
| > | ||
| {nextPayment.amount.currencySymbol} | ||
| {nextPayment.amount.amountFormatted} |
There was a problem hiding this comment.
this will be updated to next_payment.totals.grand_total once #8739 is merged
| : null; | ||
| const seatsTotalTier = subscriptionItem.seats?.tiers?.find(t => t.total.amount > 0); | ||
| const monthLabel = t(localizationKeys('billing.month')).toLowerCase(); | ||
| const seatLimitAndIncludedSeatsLocalizationKey = |
There was a problem hiding this comment.
Nit: this conditional is very hard to scan
There was a problem hiding this comment.
it's so bad :/ any suggestions? It's just picking a specific localization key, so doesn't feel weighty enough to extract to a separate component.
2 participants
Description
This PR renders per-seat cost details for subscription items in the SubscriptionsList.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change