Bug 1837680: Add Message-ID header when missing at send

[kanru]

Detect whether a Message-ID header has been included in the message passed to MessageToMTA and generate one if it's missing.

GMail and other modern mail services now expect a Message-ID as part of the message else they mark them as spam or drop them entirely.

Details

Add a default Message-ID builder and add it to message header if there isn't already one. This change is based on #146

Additional info

• bug#1837680

Test Plan

not verified yet

1. Register a new account with an email address
2. Verify that the sign-up email has correct Message-ID header

[mrenvoize]

Is this not just a direct copy of #146

[justdave]

This appears to be an additional change on top of #146, and it's really hard to see because the branch contains a merge commit instead of containing the commit from the other PR and then the new one on top of it.

This PR applies the following change on top of #146:

diff --git a/Bugzilla/Mailer.pm b/Bugzilla/Mailer.pm
index e0e0f49ad..3943dc899 100644
--- a/Bugzilla/Mailer.pm
+++ b/Bugzilla/Mailer.pm
@@ -283,7 +283,7 @@ sub build_message_id {
     $user_id = Bugzilla->user->id;
   }

-  my $sitespec = '@' . Bugzilla->localconfig->urlbase;
+  my $sitespec = '@' . Bugzilla->params->{'urlbase'};
   $sitespec =~ s/:\/\//\./;               # Make the protocol look like part of the domain
   $sitespec =~ s/^([^:\/]+):(\d+)/$1/;    # Remove a port number, to relocate
   if ($2) {