✨ per-side border support#96
Merged
Merged
Conversation
|
Size Increased — +1.8 KB 112.2 KB unpacked |
commit: |
Collaborator
Author
|
dreyfus92
reviewed
Jun 11, 2026
dreyfus92
left a comment
dreyfus92
left a comment
Member
There was a problem hiding this comment.
looks good overall just left a comment 👀
expands per-side border attributes to allow for fg, width, bg properties for each side of the border
As we add features to the wire format, this makes is simplier to adjust the memory allocation of the wasm For example, the PR can add 24 new bytes of memory to an element operation that defines border properties probably not a big deal, but its nice to keep it in mind
rauhryan
force-pushed
the
per-side-border-69
branch
from
2902494 to
ea06359
Compare
dreyfus92
approved these changes
Jun 14, 2026
cowboyd
approved these changes
Jun 24, 2026
cowboyd
left a comment
cowboyd
left a comment
Collaborator
There was a problem hiding this comment.
I think is ok to put transformation stuff in the ops layer for now.
Member
|
thank you both ✌🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds per-side border support
Closes #
Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure