WS-70 - Update Inline JS in to meet new coding standards: ATI Analytics#14119
Open
holchris wants to merge 27 commits into
Open
WS-70 - Update Inline JS in to meet new coding standards: ATI Analytics#14119holchris wants to merge 27 commits into
holchris wants to merge 27 commits into
Conversation
shayneahchoon
approved these changes
Jun 17, 2026
LilyL0u
reviewed
Jun 17, 2026
LilyL0u
reviewed
Jun 17, 2026
…ine-js-in-to-meet-new-coding-standards-ati-analytics
Louis-Matsika
approved these changes
Jun 22, 2026
…ng-standards-ati-analytics
…ng-standards-ati-analytics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: WS-70
Summary
This PR updates
addSendStaticBeaconToWindowandsendPageViewBeaconOperaMinito follow coding standards to maintain inline JSCode changes
CanonicalATIAnalyticsandsendPageViewBeaconOperaMinito pass inline script functions and explicit parameters intoaddScriptaddSendStaticBeaconToWindowandsendPageViewBeaconOperaMiniaddSendStaticBeaconToWindowfrom a string inline script into an actual function moduleaddInLineScriptso it can accept parameters and embed them directly viatoString()sendPageViewBeaconOperaMinidirectly while preserving coverage for beacon sending, referrer handling, single-run protection, and non-Opera behaviorTesting
Useful Links