[WS-2650]: Sign-in popup banner implementation#14082
Merged
Merged
Conversation
…sign-in-popup-banner-implementation
…/github.com/bbc/simorgh into WS-2650-sign-in-popup-banner-implementation
…/github.com/bbc/simorgh into WS-2650-sign-in-popup-banner-implementation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements the WS-2650 guest sign-in prompt as a modal dialog surfaced from the “Save for later” guest flow, reusing the existing Account promotional banner content while adding modal-specific layout and focus management.
Changes:
- Added
AccountSignInModal(dialog + backdrop + Escape/close handling) and auseTrappedFocushook for focus trapping. - Extended
PromotionalBannerto support a top image slot and style overrides, enabling reuse inside the modal. - Updated the guest save button to open the modal, and added a Storybook entry to preview the modal state.
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/hooks/useTrappedFocus/index.ts | New focus-trap hook used by the modal. |
| src/app/components/SaveArticleButton/SaveArticleButtonGuest/index.tsx | Opens the sign-in modal for signed-out users. |
| src/app/components/PromotionalBanner/index.types.ts | Adds topImage and styleOverrides types. |
| src/app/components/PromotionalBanner/index.tsx | Renders topImage and applies style overrides. |
| src/app/components/PromotionalBanner/index.test.tsx | Adds test coverage for topImage placement. |
| src/app/components/Account/SignInPromotionalBanner/index.tsx | New banner composition for modal sign-in prompt. |
| src/app/components/Account/SignInPromotionalBanner/index.styles.tsx | Styles and responsive imagery for the modal banner. |
| src/app/components/Account/AccountSignInModal/index.tsx | New modal wrapper with inert/background handling and focus trap usage. |
| src/app/components/Account/AccountSignInModal/index.styles.tsx | Modal/backdrop styling and responsive sizing. |
| src/app/components/Account/AccountPromotionalBanner/index.stories.tsx | Adds Storybook story for signed-out modal state. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…/github.com/bbc/simorgh into WS-2650-sign-in-popup-banner-implementation
elvinasv
reviewed
Jun 12, 2026
jinidev
reviewed
Jun 12, 2026
jinidev
reviewed
Jun 12, 2026
…/github.com/bbc/simorgh into WS-2650-sign-in-popup-banner-implementation
jinidev
approved these changes
Jun 19, 2026
Louis-Matsika
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2650
Summary
Adds a sign-in popup modal that surfaces the account promotional banner in a focus-trapped, dismissible dialog with responsive imagery.
Code changes
AccountSignInModalcomponent with backdrop, focus trapping and Escape/click-to-close handling.useTrappedFocushook to keep keyboard focus within the modal.Testing
yarn devand open a hindi article (e.g./hindi/articles/c0469479x9xo) (The user should not be signed in).Useful Links
Figma design: https://www.figma.com/design/8xqdz6WAYt2QpcLguVBCFz/WS-Sign-In-prompt?node-id=117-4210&p=f&t=bLX9drCEGAV2HoZj-0