android_application: add executable bits for some shell scripts#517
Closed
06393993 wants to merge 1 commit into
Closed
android_application: add executable bits for some shell scripts#51706393993 wants to merge 1 commit into
06393993 wants to merge 1 commit into
Conversation
`gen_android_feature_manifest.sh` and `gen_priority_android_feature_manifest.sh` are both direclty used in the executable fields in `ctx.actions.run` in `_create_feature_manifest`. If they don't have the executables bit, the action fails with permission denied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_android_feature_manifest.shandgen_priority_android_feature_manifest.share both direclty used in the executable fields inctx.actions.runin_create_feature_manifest. If they don't have the executables bit, the action fails with permission denied.An alternative is to create
sh_binarytargets for those*.shfiles, if we prefer that instead of modifying the file metadata, please let me know.