[v2] Refactor to standalone source HeadObject for copies#10375
Closed
hssyoo wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing because the tag count optimization turns out to be infeasible. The issue is that
Currently, S3 commands with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
HeadObjectcalls during S3 to S3 multipart copies. Currently, theHeadObjectrequest is called inSetMetadataDirectivePropsSubscriber. This isn't ideal since it couplesHeadObjectinvocations to a specific subscriber. We want to open it up so that other subscribers can consume theHeadObjectresponse, even ifSetMetadataDirectivePropsSubscribernever fires.Specifically, this refactor unblocks the following future changes:
SetTagsSubscriberso it only fires ifTagCountinHeadObjectresponse is greater than 0.--copy-props(egtagging) in the future, then these values can be fetched and copied independently from metadata.