feat: parameterize embedding service port and update configuration do…#4
Conversation
Greptile SummaryThis PR parameterizes the embedding service's listen port via a new
Confidence Score: 5/5Safe to merge; changes are limited to startup configuration and documentation with no impact on the embedding logic. The port-parsing addition is straightforward and addresses the previously flagged raw-string-to-bind issue. The only gap is that port 0 passes the u16 check and would cause the OS to assign an ephemeral port silently, but this edge case is unlikely in practice and does not affect the service's normal operation. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "linting" | Re-trigger Greptile |
| ## Configuration | ||
|
|
||
| Configured via environment variables (set them in `.env`): | ||
|
|
There was a problem hiding this comment.
Possible default mismatch for
EMBEDDING_MODELS
The table documents the default as nomic, but the Dockerfile's ARG EMBEDDING_MODELS=nomic,bge-small suggests both models are baked into the image during the warmup step. Could you confirm what the actual runtime default is in the Rust library? If the service loads both models by default, the table entry should be updated to nomic,bge-small to match.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
… improve error handling for port parsing
…cumentation
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)