fix: Do not raise KeyError in parse_sitemap when partial options are provided#1940
Merged
Conversation
…provided ParseSitemapOptions is a TypedDict with total=False, so all keys are optional, but parse_sitemap read three of them with direct subscripting, raising KeyError for any partial options dict. Read all options with .get() and defaults instead.
vdusek
added
t-tooling
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1940 +/- ##
==========================================
+ Coverage 92.85% 92.86% +0.01%
==========================================
Files 167 167
Lines 11714 11709 -5
==========================================
- Hits 10877 10874 -3
+ Misses 837 835 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ParseSitemapOptionsis declared asTypedDict(total=False), so every key is optional, butparse_sitemapreademit_nested_sitemaps,max_depth, andsitemap_retrieswith direct subscripting. Any caller passing a partial options dict (e.g. justtimeout) viaSitemap.load(),Sitemap.parse(), orparse_sitemap()hit aKeyError..get()and the existing defaults, collapsing the duplicatedif/elsebranches.