[ISSUE #10419] Fix NPE when class filter route data is missing#10420
Open
yin-bo-Final wants to merge 1 commit into
Open
[ISSUE #10419] Fix NPE when class filter route data is missing#10420yin-bo-Final wants to merge 1 commit into
yin-bo-Final wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
This PR avoids a potential
NullPointerExceptioninPullAPIWrapper#computePullFromWhichFilterServerwhen class filter is enabled but the local topic route table does not contain route data for the target topic.Instead of dereferencing a missing
TopicRouteData, the code falls through to the existingMQClientExceptionpath.How Did You Test This Change?
mvn -pl client -Dtest=org.apache.rocketmq.client.impl.consumer.PullAPIWrapperTest -Djacoco.skip=true testThe test passed with
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0.