Fixed more ternary concatenation bugs

[mbien]

inspired by #9459

I ran:

"possible bug: ambiguous ternary concatenation":
$pre + $nullable != null ? $a : $b =>
$pre + ($nullable != null ? $a : $b)
;;

"possible bug: ambiguous ternary concatenation":
$pre + $nullable == null ? $a : $b =>
$pre + ($nullable == null ? $a : $b)
;;

Eval order is from left to right which can lead to undesired effects when the right side has a ternary operator.

This puts the ternary operation in braces (or avoids the situation by other means)

[tmysik]

Looks good to me, thank you

[neilcsmith-net]

LGTM. Thanks. A nasty hidden one this. Hopefully nothing is relying on the wrong behaviour! 😆

[matthiasblaesing]

Looks good to me.

Side question: Would you mind elaborating how "I ran" works in practice?

[mbien]

Side question: Would you mind elaborating how "I ran" works in practice?

of course! you can simply put the above mentioned rules it into a hint file (e.g foo.hint) and run it via single-file run action (e.g right click menu) (#3171).

But I like to put reuseable rules into [nb_config]/config/rules which is picked up by the editor automatically on save. There is also UI for that but it is a bit hidden. (example hint files)

Running a hint file will open the "inspect and transform" refactoring dialog and ask you about the scope. I have a project group with all NB modules, so i selected "all opened projects" and ran it. (warning: can take little while since its a lot of modules)