Skip to content

[FLINK-39818][ci] Filter org.eclipse.parsson:parsson false positive for Elasticsearch connector#28291

Merged
reswqa merged 1 commit into
apache:masterfrom
reswqa:add-parsson-filter
Jun 11, 2026
Merged

[FLINK-39818][ci] Filter org.eclipse.parsson:parsson false positive for Elasticsearch connector#28291
reswqa merged 1 commit into
apache:masterfrom
reswqa:add-parsson-filter

Conversation

@reswqa

@reswqa reswqa commented Jun 2, 2026

Copy link
Copy Markdown
Member

What is the purpose of the change

elasticsearch-java client depends on parsson for JSON parsing, but it fails to pass the JarFileChecker (due to the presence of GPL 2.0 in the License). Howeverorg.eclipse.parsson:parsson use GPL-2.0-with-Classpath-exception or EPL-2.0 license. I think it's ok to ship it into uber jar per Apache license policy Catagory B(https://www.apache.org/legal/resolved.html#category-b)

This block apache/flink-connector-elasticsearch#156.

The license in the header of parsson source code

/*
 * Copyright (c) 2013, 2021 Oracle and/or its affiliates. All rights reserved.
 *
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License v. 2.0, which is available at
 * http://www.eclipse.org/legal/epl-2.0.
 *
 * This Source Code may also be made available under the following Secondary
 * Licenses when the conditions for such availability set forth in the
 * Eclipse Public License v. 2.0 are satisfied: GNU General Public License,
 * version 2 with the GNU Classpath Exception, which is available at
 * https://www.gnu.org/software/classpath/license.html.
 *
 * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
 */

Brief change log

  • Add parsson to the whitelist of JarFileChecker

Verifying this change

Manually testing

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

Was generative AI tooling used to co-author this PR?

No

@flinkbot

flinkbot commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa

reswqa commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

cc @tisonkun.

Since I'm not particularly familiar with the license compliance issues, could you please review this? Thanks.

@reswqa reswqa requested a review from tisonkun June 11, 2026 07:36

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dependency only used in CLASSPATH, i.e., we don't modify its code?

If so, this exclusion should be fine.

ASF's policy can be found at https://www.apache.org/legal/resolved.html

Both EPL and GPLv2 with classpath exception are explained.

@reswqa

reswqa commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

Is this dependency only used in CLASSPATH, i.e., we don't modify its code?

Yes, we just ship it into uber jar without any code changes.

Thanks for the quick review 👍

@reswqa reswqa merged commit f14ce1e into apache:master Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants