[FLINK-39818][ci] Filter org.eclipse.parsson:parsson false positive for Elasticsearch connector#28291
Merged
Merged
Conversation
…or Elasticsearch connector
Collaborator
Member
Author
|
cc @tisonkun. Since I'm not particularly familiar with the license compliance issues, could you please review this? Thanks. |
tisonkun
approved these changes
Jun 11, 2026
tisonkun
left a comment
Member
There was a problem hiding this comment.
Is this dependency only used in CLASSPATH, i.e., we don't modify its code?
If so, this exclusion should be fine.
ASF's policy can be found at https://www.apache.org/legal/resolved.html
Both EPL and GPLv2 with classpath exception are explained.
Member
Author
Yes, we just ship it into uber jar without any code changes. Thanks for the quick review 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
elasticsearch-javaclient depends onparssonfor JSON parsing, but it fails to pass theJarFileChecker(due to the presence of GPL 2.0 in the License). Howeverorg.eclipse.parsson:parssonuseGPL-2.0-with-Classpath-exceptionorEPL-2.0license. I think it's ok to ship it into uber jar per Apache license policy Catagory B(https://www.apache.org/legal/resolved.html#category-b)This block apache/flink-connector-elasticsearch#156.
The license in the header of parsson source code
Brief change log
Verifying this change
Manually testing
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
No