Skip to content

[fix](auto partition) keep load row metrics monotonic for auto partition #64109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sollhui merged 1 commit into from
Jun 5, 2026
Merged

[fix](auto partition) keep load row metrics monotonic for auto partition #64109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions be/src/exec/sink/vrow_distribution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

#include "common/cast_set.h"
#include "common/logging.h"
#include "common/metrics/doris_metrics.h"
#include "common/status.h"
#include "core/assert_cast.h"
#include "core/column/column.h"
Expand Down Expand Up @@ -416,8 +415,6 @@ Status VRowDistribution::_deal_missing_map(const Block& input_block, Block* bloc
rows_stat_val -= new_bt_rows - old_bt_rows;
_state->update_num_rows_load_total(old_bt_rows - new_bt_rows);
_state->update_num_bytes_load_total(old_bt_bytes - new_bt_bytes);
DorisMetrics::instance()->load_rows->increment(old_bt_rows - new_bt_rows);
DorisMetrics::instance()->load_bytes->increment(old_bt_bytes - new_bt_bytes);

return Status::OK();
}
Expand Down
7 changes: 5 additions & 2 deletions be/src/exec/sink/writer/vtablet_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2064,6 +2064,7 @@ Status VTabletWriter::write(RuntimeState* state, doris::Block& input_block) {
// check out of limit
RETURN_IF_ERROR(_send_new_partition_batch());

const bool is_replaying_batched_block = _row_distribution._deal_batched;
auto rows = input_block.rows();
auto bytes = input_block.bytes();
if (UNLIKELY(rows == 0)) {
Expand All @@ -2078,8 +2079,10 @@ Status VTabletWriter::write(RuntimeState* state, doris::Block& input_block) {
// the real 'num_rows_load_total' will be set when sink being closed.
_state->update_num_rows_load_total(rows);
_state->update_num_bytes_load_total(bytes);
DorisMetrics::instance()->load_rows->increment(rows);
DorisMetrics::instance()->load_bytes->increment(bytes);
if (!is_replaying_batched_block) {
DorisMetrics::instance()->load_rows->increment(rows);
DorisMetrics::instance()->load_bytes->increment(bytes);
}

_row_distribution_watch.start();
RETURN_IF_ERROR(_row_distribution.generate_rows_distribution(
Expand Down
7 changes: 5 additions & 2 deletions be/src/exec/sink/writer/vtablet_writer_v2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,7 @@ Status VTabletWriterV2::write(RuntimeState* state, Block& input_block) {
// check out of limit
RETURN_IF_ERROR(_send_new_partition_batch());

const bool is_replaying_batched_block = _row_distribution._deal_batched;
auto input_rows = input_block.rows();
auto input_bytes = input_block.bytes();
if (UNLIKELY(input_rows == 0)) {
Expand All @@ -504,8 +505,10 @@ Status VTabletWriterV2::write(RuntimeState* state, Block& input_block) {
// the real 'num_rows_load_total' will be set when sink being closed.
_state->update_num_rows_load_total(input_rows);
_state->update_num_bytes_load_total(input_bytes);
DorisMetrics::instance()->load_rows->increment(input_rows);
DorisMetrics::instance()->load_bytes->increment(input_bytes);
if (!is_replaying_batched_block) {
DorisMetrics::instance()->load_rows->increment(input_rows);
DorisMetrics::instance()->load_bytes->increment(input_bytes);
}

SCOPED_RAW_TIMER(&_send_data_ns);
// This is just for passing compilation.
Expand Down
Loading