Bump structlog to 26.1.0 and drop WRITE_LOCKS workaround#68168
Open
wjddn279 wants to merge 2 commits into
Open
Bump structlog to 26.1.0 and drop WRITE_LOCKS workaround#68168wjddn279 wants to merge 2 commits into
wjddn279 wants to merge 2 commits into
Conversation
wjddn279
requested review from
amoghrajesh,
ashb,
bugraoz93,
dheerajturaga,
kaxil and
potiuk
as code owners
Contributor
Author
|
waiting until |
wjddn279
force-pushed
the
remove-temporal-logic-and-update-struclog
branch
2 times, most recently
from
ad75d24 to
eae215a
Compare
wjddn279
force-pushed
the
remove-temporal-logic-and-update-struclog
branch
2 times, most recently
from
580fbb6 to
ce510ca
Compare
structlog 26.1.0 ships the upstream fix for file-descriptor write locks leaking after their file is closed, which Airflow previously worked around by swapping structlog's WRITE_LOCKS dict for a WeakKeyDictionary at logging-configuration time. Now that the fix is released, remove that monkey-patch and raise the structlog lower bound to >=26.1.0 across all distributions so the workaround is no longer required.
wjddn279
force-pushed
the
remove-temporal-logic-and-update-struclog
branch
from
ce510ca to
ae4353d
Compare
wjddn279
changed the title
uranusjr
approved these changes
Jun 12, 2026
Member
|
I believe only the shared logging package’s dependency needs bumping. But it’s not a bad idea to keep everything in sync. |
amoghrajesh
approved these changes
Jun 12, 2026
amoghrajesh
left a comment
amoghrajesh
left a comment
Contributor
There was a problem hiding this comment.
LGTM +1
@uranusjr if we bump the shared package's version, we have a prek hook that synchronises it for all consuming packages
ashb
requested changes
Jun 12, 2026
ashb
left a comment
ashb
left a comment
Member
There was a problem hiding this comment.
This should have produced changes to uv.lock too
ashb
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #65121
As the
struclogrelease the version (26.1.0, https://github.com/hynek/structlog/releases/tag/26.1.0) including the fix of the issue, remove the workaround and bump the version constraintWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.