Assemblée Générale - Déclaration des entités Doctrine#2294
Open
vgreb wants to merge 2 commits into
Open
Conversation
stakovicz
reviewed
Jun 10, 2026
Comment on lines
+28
to
+36
| public ?\DateTime $dateOuverture { | ||
| set(?\DateTime $dateOuverture) { | ||
| $this->dateOuverture = $dateOuverture; | ||
| if ($dateOuverture !== null) { | ||
| $this->dateCreation ??= $dateOuverture; | ||
| $this->etat = QuestionEtat::Ouverte; | ||
| } | ||
| } | ||
| } |
|
|
||
| public QuestionEtat $etat = QuestionEtat::EnAttente; | ||
|
|
||
| public function hasStatusWaiting(): bool |
Contributor
There was a problem hiding this comment.
Il faut le franciser aussi, non ?
Collaborator
Author
There was a problem hiding this comment.
Je ne sais pas trop, est-ce que c'est considéré comme du métier ici ?
On utiliserait quoi ? estEnAttente(), estOuverte() et estFermee() ?
Contributor
There was a problem hiding this comment.
Pourquoi avoir besoin de ces 3 méthodes si c'est déjà un enum en fait ?
Collaborator
Author
There was a problem hiding this comment.
Ces méthode existaient dans l'entité Ting, après j'ai pas de préférence entre faire directement la condition ou l'appel à la méthode.
La méthode est plus lisible, mais la condition est plus explicite.
Mopolo
reviewed
Jun 10, 2026
vgreb
force-pushed
the
refacto/assemblee-generale-doctrine-1
branch
2 times, most recently
from
ff0b678 to
e3ee59e
Compare
vgreb
force-pushed
the
refacto/assemblee-generale-doctrine-1
branch
from
e3ee59e to
7ea5023
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2290